search

krzysztofslusarski / continuous-async-profiler

Spring boot library for continuous profiling with async-profiler
Apache License 2.0
30 stars 5 forks source link

Autoconfiguration should be disableable with obvious named parameter #32

Open michaldo opened 1 year ago

michaldo commented 1 year ago

async-profiler.continuous.load-native-library = true - if the tool should load native async-profiler library (turning off disables starter permanently)

It is not true, because autoconfiguration starts unconditionally. It can be easy fixed, but it is an opportunity to review naming convention

In my opinion async-profiler.continuous.load-native-library does not sound like profiler turn on/off permanently. async-profiler.continuous.enabled sounds. That works for many other autoconfigurations.

But word enabled is already used for something similar to stop-work-file My proposal is: async-profiler.continuous.load-native-library -> async-profiler.continuous.enabled async-profiler.continuous.enabled -> async-profiler.continuous.stopped

krzysztofslusarski commented 1 year ago

I'm OK with that, but that change will not be backward compatible, so I would prefer to do it with 3.0 version, which will be released after async-profiler 3.0 is released.