search

krzysztofzablocki / Inject

Hot Reloading for Swift applications!
MIT License
2.1k stars 114 forks source link

Please update "-Xlinker -interposable" instruction. #80

Closed Samback closed 9 months ago

Samback commented 9 months ago

@krzysztofzablocki first of all BIG thanks for your library! One issue I faced during integration was a misunderstanding with adding '-Xlinker -interposable' in the config. I believe it would be helpful for everyone to avoid the mistake I made. Note that these flags should be separated and added independently.

-Xlinker
-interposable

Regards, Max

johnno1962 commented 9 months ago

Hi, Yes, this is a new feature of Xcode 15 where it makes a point of quoting these options together and due to how the linker parses its options you don't get an error or warning. I had to tweak the InjectionII README for this:


It's also important to add "-Xlinker -interposable" (without the double quotes and on separate lines)
Samback commented 9 months ago

@johnno1962 It took me a couple of hours to realize where the mistake was because I was implementing Inject for the first time. It felt like a bad joke when I followed all the steps correctly, and it didn't work, but it works perfectly on the demo app.

johnno1962 commented 9 months ago

Perhaps you could contribute a PR with some revised wording?

krzysztofzablocki commented 9 months ago

updated