krzysztofzablocki / crafter

Crafter - Xcode project configuration CLI made easy.
twitter.com/merowing_
547 stars 35 forks source link

Fix operator precedence bug #12

Closed marcboquet closed 9 years ago

marcboquet commented 9 years ago

Would fail with "undefined method empty?' for nil:NilClass" if@build_settingswasnil`.

I prefer explicit "old school" operators in this case, but it could also work reversing it: ... unless @build_settings.empty? if @build_settings

krzysztofzablocki commented 9 years ago

Hehe I looked at it yesterday and was thinking 'was I drunk when I wrote this lines?' thanks :+1:

marcboquet commented 9 years ago

:wine_glass: :thumbsup: