search

krzyzanowskim / Natalie

Natalie - Storyboard Code Generator (for Swift)
http://blog.krzyzanowskim.com/2015/04/15/natalie-storyboard-code-generator/
MIT License
1.17k stars 74 forks source link

Storyboard struct -instantiate* methods now return class types qualified by module #115

Closed nhojb closed 6 years ago

nhojb commented 6 years ago

This fixes issue #114, where instantiating a view controller with the same name as the storyboard would resolve to the Storyboard struct type, not the module's view controller type.

phimage commented 6 years ago

Hi, To test your modification, you can generate the Storyboards.swift files from the NatalieExample projects. This will show if there is no compilation issue with simple case.

This must be tested with controller from swift framework also.

nhojb commented 6 years ago

NatalieExample targets compile without error - Storyboard diffs are attached.

I'll add a test with a swift framework later.

ExampleStoryboards.diff.txt OSXExampleStorboards.diff.txt

krzyzanowskim commented 6 years ago

It's ok to commit the changes to examples.

nhojb commented 6 years ago

Just created a new PR with the updated examples and inclusion of a framework view controller. Includes the same (core) changes as this PR.

krzyzanowskim commented 6 years ago

hm... close this one without merge then? btw. you can update PR's by simply commit and push more.