Issue with inheritance - Githubissues

Hi,

I recently faced an issue with Natalie. Given the following architecture:

class A: UIViewController {}
class B: A {}

with both A and B identifiable view controllers in my Storyboard.

Natalie generates this code that doesn't compile:


//MARK: - AViewController
extension AViewController: IdentifiableProtocol { 
    var storyboardIdentifier: String? { return "AViewController" }
    static var storyboardIdentifier: String? { return "AViewController" }
}

//MARK: - BViewController
extension BViewController: IdentifiableProtocol { 
    var storyboardIdentifier: String? { return "BViewController" }
    static var storyboardIdentifier: String? { return "BViewController" }
}

and generates the following errors:

./Storyboards.swift:248:9: error: overriding declaration requires an 'override' keyword
    var storyboardIdentifier: String? { return "BViewController" }
        ^
./Storyboards.swift:241:9: note: overridden declaration is here
    var storyboardIdentifier: String? { return "AViewController" }
        ^
./Storyboards.swift:249:16: error: overriding declaration requires an 'override' keyword
    static var storyboardIdentifier: String? { return "BViewController" }
               ^
./Storyboards.swift:242:16: note: overridden declaration is here
    static var storyboardIdentifier: String? { return "AViewController" }
               ^
./Storyboards.swift:249:16: error: class var overrides a 'final' class var
    static var storyboardIdentifier: String? { return "BViewController" }
               ^
./Storyboards.swift:242:16: note: overridden declaration is here
    static var storyboardIdentifier: String? { return "AViewController" }
               ^
./Storyboards.swift:247:28: error: redundant conformance of 'BViewController' to protocol 'IdentifiableProtocol'
extension BViewController: IdentifiableProtocol { 
                           ^
./BViewController.swift:11:7: note: 'BViewController' inherits conformance to protocol 'IdentifiableProtocol' from superclass here
class BViewController: AViewController {
      ^

Here is a sample project reproducing the issue: https://github.com/delannoyk/NatalieInheritanceIssue

krzyzanowskim / Natalie

Issue with inheritance #78