Closed waltermvp closed 6 years ago
what kind of errors? can you make an example project?
Here is a blank project with IBAnimatable and Natalie. See if you get the error: IBAnimatableNatalieError.zip
/Users/cupojoe/Code_Repos/NatalieError/IBAnimatableNatalieError/IBAnimatableNatalieError/Storyboards.swift:239:9: Property 'storyboardIdentifier' must be declared public because it matches a requirement in public protocol 'IdentifiableProtocol'
Edit: please, not this is a local build of Natalie based on master, since the inheritance issue (#78) hasn't made it to the build yet it would seem.
one more question. do you use master branch, or last release? I should do the release with the latest fixes
We are using the release of IBAnimatable (Cocoa Pods) and the master of Natalie, built from source.
the code is
output += "extension IdentifiableProtocol where Self: \(customClass) {\n"
if viewController.customModule != nil {
output += " var storyboardIdentifier: String? { return \"\(storyboardIdentifier)\" }\n"
} else {
output += " public var storyboardIdentifier: String? { return \"\(storyboardIdentifier)\" }\n"
}
customModule is not nil (because of IBAnimatable module is used)
I do not remember why there is this two case
duplicate of new one with more information #124
I'm not even sure if a fix is possible since it's caused by a third party dependency. But I get build errors when Natalie generates code for a view controller that is subclassed from
AnimatableViewController
of IBAnimatable