krzyzanowskim / OpenSSL

OpenSSL package for SwiftPM, CocoaPod, and Carthage, multiplatform
https://swift.best
Other
907 stars 334 forks source link

#150 Keep file naming consistency. #151

Closed Romick2005 closed 11 months ago

Romick2005 commented 2 years ago

Fix openssl include issue on case sensitive file systems.

krzyzanowskim commented 2 years ago

thank you for this change. Unfortunately, I don't merge external binaries due to security reasons.

The proper solution to the problem is to update build scripts to change headers as part of a build step. Would that be something you're willing to do?

Romick2005 commented 2 years ago

Yes I would like to try, but not quite sure how to make build. Would be great if build command was mentioned in readme or some docs. I did not quite get you, what do you mean by external binaries if changes are only within github source repo without any external links. Can you please explain this, if that is not so complex topic. Thank you!

krzyzanowskim commented 2 years ago

Build is https://github.com/krzyzanowskim/OpenSSL#build

Screen Shot 2022-07-13 at 23 35 26@2x

I did not quite get you, what do you mean by external binaries

that basically apply to changes to the Frameworks directory etc that is a result of building scripts and that I'm the only provider.

Screen Shot 2022-07-13 at 23 36 01@2x

anyway, any changes to these files will be overridden by the next run of build scripts

There' two scripts https://github.com/krzyzanowskim/OpenSSL/tree/master/scripts that you'd need to update

Romick2005 commented 2 years ago

Great, thank you! So which name would you prefer OpenSSL or openssl?

krzyzanowskim commented 2 years ago

"OpenSSL", that's the name of the clang/swift module

krzyzanowskim commented 1 year ago

overall I don't think that works. Change path openssl to OpenSSL is one thing, but then all headers should use eg. # include <OpenSSL/opensslconf.h> instead default # include <openssl/opensslconf.h>

krzyzanowskim commented 11 months ago

Closing this PR. The upcoming version 3.1.2 has the case-sensitive issue addressed