Closed richardtop closed 1 year ago
Hi @krzyzanowskim, any comments regarding this PR? I'd be very happy to get this merged, since I'm using this repository to build my own artifacts and by default (just by cloning) it doesn't work without this fix.
Here's what I'm getting if I just run make
with the existing master
branch of this repository:
user@mac OpenSSL_gh_test % make 14:50:15
OPENSSL_VERSION="1.1.1q" /Users/user/Developer/OpenSSL_gh_test/scripts/build.sh
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 9632k 100 9632k 0 0 9917k 0 --:--:-- --:--:-- --:--:-- 9982k
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 65 100 65 0 0 316 0 --:--:-- --:--:-- --:--:-- 340
patching file test/v3ext.c
Building for iPhoneSimulator i386
Configuring for iPhoneSimulator i386
Building /var/folders/c9/2300142s71n49wc4sqf_8f89j48c00/T/tmp.tvwkxXtg/1.1.1q-iPhoneSimulator-i386.build.log
patching file test/v3ext.c
Building for iPhoneSimulator x86_64
Configuring for iPhoneSimulator x86_64
Building /var/folders/c9/2300142s71n49wc4sqf_8f89j48c00/T/tmp.tvwkxXtg/1.1.1q-iPhoneSimulator-x86_64.build.log
patching file test/v3ext.c
Building for iPhoneSimulator arm64
Configuring for iPhoneSimulator arm64
Building /var/folders/c9/2300142s71n49wc4sqf_8f89j48c00/T/tmp.tvwkxXtg/1.1.1q-iPhoneSimulator-arm64.build.log
patching file test/v3ext.c
Building for iPhoneOS armv7
Configuring for iPhoneOS armv7
Building /var/folders/c9/2300142s71n49wc4sqf_8f89j48c00/T/tmp.tvwkxXtg/1.1.1q-iPhoneOS-armv7.build.log
patching file test/v3ext.c
Building for iPhoneOS armv7s
Configuring for iPhoneOS armv7s
Building /var/folders/c9/2300142s71n49wc4sqf_8f89j48c00/T/tmp.tvwkxXtg/1.1.1q-iPhoneOS-armv7s.build.log
patching file test/v3ext.c
Building for iPhoneOS arm64
Configuring for iPhoneOS arm64
Building /var/folders/c9/2300142s71n49wc4sqf_8f89j48c00/T/tmp.tvwkxXtg/1.1.1q-iPhoneOS-arm64.build.log
patching file test/v3ext.c
Building for MacOSX x86_64
Configuring for MacOSX x86_64
Building /var/folders/c9/2300142s71n49wc4sqf_8f89j48c00/T/tmp.NsCoGkQJ/1.1.1q-MacOSX-x86_64.build.log
patching file test/v3ext.c
Building for MacOSX arm64
Configuring for MacOSX arm64
Building /var/folders/c9/2300142s71n49wc4sqf_8f89j48c00/T/tmp.NsCoGkQJ/1.1.1q-MacOSX-arm64.build.log
patching file test/v3ext.c
Building for MacOSX_Catalyst x86_64
Configuring for MacOSX_Catalyst x86_64
Building /var/folders/c9/2300142s71n49wc4sqf_8f89j48c00/T/tmp.9N6R72rI/1.1.1q-MacOSX_Catalyst-x86_64.build.log
patching file test/v3ext.c
Building for MacOSX_Catalyst arm64
Configuring for MacOSX_Catalyst arm64
Building /var/folders/c9/2300142s71n49wc4sqf_8f89j48c00/T/tmp.9N6R72rI/1.1.1q-MacOSX_Catalyst-arm64.build.log
/Users/user/Developer/OpenSSL_gh_test/scripts/create-frameworks.sh
*******************************************
note: Building targets in dependency order
/Users/user/Developer/OpenSSL_gh_test/OpenSSL.xcodeproj: error: No signing certificate "Developer ID Application" found: No "Developer ID Application" signing certificate matching team ID "67RAULRX93" with a private key was found. (in target 'OpenSSL (macOS)' from project 'OpenSSL')
** BUILD FAILED **
make: *** [frameworks] Error 65
user@mac OpenSSL_gh_test %
Here's what I'm getting if I just run make with the existing master branch of this repository
this is expected and not obvious how to workaround with Xcode. 67RAULRX93 is what I use to ship the binary. Please revert
Clear, should I close this PR and update the Readme.md
instructions instead? I guess, nothing in this PR will be of any help then.
In the current shape this project has code signing enabled with some team selected by default. This prevents it from building on someone else's machine / in a CI environment, as I don't have those private keys / certificates installed.
The solution is to disable signing. After this fix, the project builds flawlessly just with the![Screen Shot 2022-08-15 at 23 54 29](https://user-images.githubusercontent.com/8013017/184717182-c3a48e52-d092-4a4a-a02f-946fc3c32088.jpg)
make
command.