search

krzyzanowskim / OpenSSL

OpenSSL package for SwiftPM, CocoaPod, and Carthage, multiplatform
https://swift.best
Other
926 stars 340 forks source link

Doesn't compile out of the box #229

Closed richardtop closed 2 weeks ago

richardtop commented 4 weeks ago

Given the following command: make SIGNING_IDENTITY="Apple Distribution"

I'm getting the following output when trying to build the OpenSSL with this repo out of the box:

/Users/user/Developer/OpenSSL-krzyzanowskim/OpenSSL.xcodeproj: error: No signing certificate "Developer ID Application" found: No "Developer ID Application" signing certificate matching team ID "67RAULRX93" with a private key was found. (in target 'OpenSSL (macOS)' from project 'OpenSSL')
note: Disabling previews because SWIFT_VERSION is set and SWIFT_OPTIMIZATION_LEVEL=-Owholemodule, expected -Onone (in target 'OpenSSL (macOS)' from project 'OpenSSL')
** BUILD FAILED **

The following build commands failed:
    Building project OpenSSL with scheme OpenSSL (macOS) and configuration Release
(1 failure)
make: *** [frameworks] Error 65

Looks like the project has signing team set:

image

This would make it impossible to build the project by anyone not having those private keys/certificates installed.

krzyzanowskim commented 4 weeks ago

67RAULRX93 is my team and you have to replace it with your value and regenerate project with tuist.

It is set in Makefile and you can override it when invoke make command. that should regenerate xcode project with new value.

SIGNING_IDENTITY ?= "Apple Distribution: Marcin Krzyzanowski (67RAULRX93)"
richardtop commented 4 weeks ago

Is there an option to have an unsigned build?

krzyzanowskim commented 4 weeks ago

there;s always an option, but not in this script. the build script is for my purpose mainly and to serve binaries served from this repository. not necessary to offer variety of options

richardtop commented 3 weeks ago

It would be great if it was possible to make the unsigned build to be the default one, so that it would just work out of the box. I was able to tweak it a little bit to get the result I want, but it is quite confusing as the user has to dig quite deep to adjust the scripts for his/hers use-case.

krzyzanowskim commented 3 weeks ago

That is not my goal. I'm happy to see proposals.

The goal of this repository to do one thing right, and that is deliver working and prebuilt openssl framework for all apple platforms.

richardtop commented 2 weeks ago

Clear, then I'll continue to use a forked version of this, as making a customizable one would be too much work and too much complexity to introduce.