search

krzyzanowskim / OpenSSL

OpenSSL package for SwiftPM, CocoaPod, and Carthage, multiplatform
https://swift.best
Other
910 stars 336 forks source link

Bitcode turned off? #78

Closed balthisar closed 4 years ago

balthisar commented 4 years ago

Just out of curiosity, why did you back out on bitcode again?

I know I can fork and re-enable it, but I'm primarily a macOS developer, trying to support iOS on something else I'm considering maintaining, and I'd love to link to your repo rather than to some other repo.

Would you consider a PR for support a command line switch that re-enables bitcode in the build.sh?

krzyzanowskim commented 4 years ago

it was an oversight in one of PR, but it's reverted alreqdy, isn't it?

balthisar commented 4 years ago

Current HEAD has bitcode turned off. But now that I think of it, I can point Carthage at a specific commit, prior to removing the bitcode compiler option.

krzyzanowskim commented 4 years ago

I'm confused. bitcode never worked. It was enabled for like a single release, by mistake, however, even then it didn't work. Bitcode is useless for macOS especially.

Do you expect to re-enable bitcode that never work, or what?

balthisar commented 4 years ago

I don't want bitcode for macOS; however the project I'm considering supporting has iOS targets, and I'd like not to break things for iOS users.

My issue was:

why did you back out on bitcode again?

If the answer is:

bitcode that never work

Then consider this issue closed.

krzyzanowskim commented 4 years ago

yea. It never worked for iOS too. I tried, but didn't find truly working solution. On the side note. bitcode doesn't "Fix" anything https://docs.microsoft.com/en-us/appcenter/diagnostics/ios-symbolication#bitcode more in the contrary.

Disabling bitcode significantly simplifies symbols management and currently does not have any known downsides for iOS apps.

ilammy commented 4 years ago

Though, I’m curious as to why it’s not possible to enable bitcode. It seems like it should be a question of adding -fembed-bitcode to the compilation pipeline (GRKOpenSSLFramework seems to do it, or at least did at some point). But I don’t actually have any real devices to test that and IIRC this is one thing that tends to work completely different on Simulators.

balthisar commented 4 years ago

I did a cursory test just to see if it worked on my Phone, and in a single use case (verifying a sandbox in-app-purchase receipt), it worked, where "work" means "didn't apparently fail."

It looks like bitcode is NOT an app store requirement for iOS, so I'll just disable bitcode for the remainder of the targets in the consuming project.

Thanks, by the way!

krzyzanowskim commented 4 years ago

Though, I’m curious as to why it’s not possible to enable bitcode. It seems like it should be a question of adding -fembed-bitcode

it should be, and I already do that https://github.com/krzyzanowskim/OpenSSL/blob/17794e6faf5928f42264a7e3ef093ea7c08c5a15/build.sh#L77. However it's not enough for an unknown reason. If you happen can make it work, I'll welcome PR with open arms ;)

Benzer1406 commented 4 years ago

Still can't compile xCode with a React Native Project of Version 0.62