search

krzyzanowskim / OpenSSL

OpenSSL package for SwiftPM, CocoaPod, and Carthage, multiplatform
https://swift.best
Other
910 stars 336 forks source link

Support bitcode for framework #87

Closed makesource closed 4 years ago

makesource commented 4 years ago

Found Issue

Although openssl binary files (libcrypto.a, libssl.a) supports bitcode (in https://github.com/krzyzanowskim/OpenSSL/pull/83)

The prebuilt Framework does not support bitcode because of the project settings.

스크린샷 2020-07-16 오후 11 06 37

So the resulting artifacts (framework) does not have any bitcode files

스크린샷 2020-07-16 오후 11 05 28

How to Fix and What This PR do

Change the setting for bitcode and then execute create_framework script to rebuild frameworks.

After that I can see the __LLVM flags in framework properly.

스크린샷 2020-07-16 오후 11 09 20

My Thinking

I think many other developers didn't know that because CocoaPods only uses binary files (libcrypto.a, libssl.a). But in my case, Carthage build frameworks through OpenSSL.xcodeproj so bitcodes setting in project does matter.

makesource commented 4 years ago

Is there anyone who check this PR?

krzyzanowskim commented 4 years ago

@makesource It looks good, but can you please remove binaries from the PR?

makesource commented 4 years ago

@krzyzanowskim This updates contains bitcode support for the binary files. Still should I remove binaries?

krzyzanowskim commented 4 years ago

yes please. I don't publish binaries not produced by myself in this repo

makesource commented 4 years ago

Oh, I got it. I will update PR soon :)