search

krzyzanowskim / OpenSSL

OpenSSL package for SwiftPM, CocoaPod, and Carthage, multiplatform
https://swift.best
Other
910 stars 336 forks source link

Could not find opensslconf-arm64.h when building for Mac arm64 #88

Closed martinpilch closed 3 years ago

martinpilch commented 4 years ago

Hi, first of all thank you for your great work! As ARM machines release is coming I'm trying to update OpenSSL in my Mac app. Using Carthage I reference to the latest version of master branch:

github "krzyzanowskim/OpenSSL" "master"

When I try to build my app for Rosetta everything works fine. But if for Any Mac I get following error:

/Carthage/Checkouts/OpenSSL/macos/include/openssl/opensslconf.h:20:11: 'openssl/opensslconf-arm64.h' file not found

Is there anything I can do to make it working? Thanks a lot!

alexcone commented 3 years ago

Something like this? opensslconf-arm64.h.zip

nielsmouthaan commented 3 years ago

Having the same issue.

@alexcone I tried including the file manually in macos/include/openssl to test it out, but I'm getting the same error so I guess Xcode isn't picking up the header. I also cloned the entire repo, added the file, updated my project's Podfile to point to the local (development) pod but that throws even more errors when building. Can you give any guidance on how to make this work or even better, provide a pull request that includes support for arm64? Would be awesome, thanks!

krzyzanowskim commented 3 years ago

I believe I have it addressed on 1.1.1-lts branch https://github.com/krzyzanowskim/OpenSSL/issues/36#issuecomment-665922429 I should find some time to make the transition to 1.1.1 sooner than later.

I don't have an intermediate workaround for that. Will look into that as soon as possible (as soon as free evening happen)

nielsmouthaan commented 3 years ago

I tried building using that branch but it still fails as opensslconf-arm64.h cannot be found. It also is not part of this directory, which is likely why it fails.

Podfile: pod 'OpenSSL-Universal', :git => 'https://github.com/krzyzanowskim/OpenSSL.git', :branch => 'marcin/1.1.1-lts'

krzyzanowskim commented 3 years ago

I tried building using that branch but it still fails as opensslconf-arm64.h cannot be found.

I fixed that. It's there now.

nielsmouthaan commented 3 years ago

Confirmed to work. Thanks! Would be great to see this ending up as an official (master) release but at this point this works for me too.

martinpilch commented 3 years ago

I can confirm it's working on marcin/1.1.1-lts. Thanks a lot!