search

ks888 / LambStatus

[Maintenance mode] Serverless Status Page System
https://lambstatus.github.io
Apache License 2.0
1.3k stars 119 forks source link

Add AdminPageCloudFrontDomainName and StatusPageCloudFrontDomainName outputs #131

Closed salekseev closed 5 years ago

salekseev commented 5 years ago

This is to be able to use with external DNS provider (e.g. Cloudflare) if using custom URLs.

This is also to address some internal work on a terraform module that I may contribute back eventually to address https://github.com/ks888/LambStatus/issues/100.

ks888 commented 5 years ago

Thank you for the PR! It seems new outputs are similar to existing AdminPageCloudFrontURL and StatusPageCloudFrontURL outputs. Can you tell me the difference?

salekseev commented 5 years ago

The difference is that if you set cutom URLs those outputs contain those URLs instead of CloudFront domain name so they cannot be used to create those needed DNS CNAMEs. Introduced outputs always output CloudFront domain names so can be used to create DNS records.

ks888 commented 5 years ago

Sorry for my late reply. I see, you want to automatically set up the DNS setting. Thank you for the clarification.