Upgrade (to 0.6.0) loses custom SSL and CNAMEs

ks888 / LambStatus

[Maintenance mode] Serverless Status Page System

https://lambstatus.github.io

Apache License 2.0

1.3k stars 119 forks source link

Upgrade (to 0.6.0) loses custom SSL and CNAMEs #96

Closed chris-scentregroup closed 6 years ago

chris-scentregroup commented 6 years ago

Carried out an upgrade, observed the following which I fixed by hand:

add back custom ssl cert usage (select my cert again)
add back Alternate Domain Names (CNAMEs)

Might indicate that we need these as params to provide in the first setup or later to modify in the stack. Apologies if this is already supported and documented.

ks888 commented 6 years ago

Sorry for inconvenience. The CloudFront distribution resource is created by the CloudFormation. When the resource is updated by the CloudFormation, the settings described in the CloudFormation template is only considered and the fixes by hand are overwritten.

Fortunately LambStatus already supports the custom domain. See this document page, and try to upgrade the stack again!

chris-scentregroup commented 6 years ago

Actioned the upgrade and it appears successful! Thank you. Issue in #95 was not resolved in turn however (we'll keep that issue open).