ks905383 / xagg

Aggregating gridded data (xarray) to polygons
https://xagg.readthedocs.io/
GNU General Public License v3.0
82 stars 15 forks source link

implement making dot product optional, restoring default agg behavior #32

Closed ks905383 closed 2 years ago

ks905383 commented 2 years ago

The dot product implementation broke some workflows and isn't faster in every instance. The default behavior (aggregating data through a for loop over polgyons) is restored, with the dot product implementation accessible through an optional impl='dot_product' argument.

One test has been added to make sure the dot_product works in the basic aggregation case, but only one test has been changed. This may cause downstream issues in the future - therefore, recommend either