Closed kerriegeil closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.48%. Comparing base (
e637331
) to head (6a3e621
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Great, thanks!
Odd that the tests are failing locally but not on the GitHub Actions, I wonder if there's something in a newer version of xarray or numpy that's changing tolerance behavior...
Fixing diag_fig to accept an xarray data array (in addition to dataset). The documentation says this is possible but it is not due to the direct call to create_raster_polygons which skips the wrapper where data arrays are converted to datasets. I've copied the dataset conversion lines to diag_fig from the pixel_overlaps wrapper.
I ran the tests and found 4 fails but they are unrelated to my edits as the fails were present beforehand. This PR includes a fix for two of the fails. They were related to trying to delete the test.nc temporary file while it is open in test_to_netcdf.
The other two fails are related to precision/tolerance, which I didn't look into. (platform win32 -- Python 3.12.4, pytest-8.2.2, pluggy-1.5.0)