search

ksahlin / strobealign

Aligns short reads using dynamic seed size with strobemers
MIT License
128 stars 16 forks source link

Fix tests to be compatible with MSVC/MinGW #282

Closed teepean closed 1 year ago

marcelm commented 1 year ago

Hi, thanks again. I am wondering: With these changes, does strobealign compile and work in MSVC/MinGW? Or are any other changes necessary?

We discussed the issue of Windows compatibility today and decided that we will not want to commit to supporting Windows, but that we are fine with pull requests that make strobealign compile on Windows if they are not too intrusive.

This PR is fine, but I’m wondering whether it is all that is needed for Windows compatibility.

teepean commented 1 year ago

Hi, thanks again. I am wondering: With these changes, does strobealign compile and work in MSVC/MinGW? Or are any other changes necessary?

We discussed the issue of Windows compatibility today and decided that we will not want to commit to supporting Windows, but that we are fine with pull requests that make strobealign compile on Windows if they are not too intrusive.

This PR is fine, but I’m wondering whether it is all that is needed for Windows compatibility.

With the PRs I have submitted the code compiles, runs and all the tests pass using both MSVC 2022 and MinGW.

marcelm commented 1 year ago

Thanks, that’s what I was hoping!