search

ksahlin / strobealign

Aligns short reads using dynamic seed size with strobemers
MIT License
128 stars 16 forks source link

Let baseline comparison fail if no reads were in the input #362

Closed marcelm closed 7 months ago

marcelm commented 7 months ago

This should ensure that the baseline comparison CI job doesn’t pass inadvertently as it did previously (see #361).

This also updates the baseline commit. To ensure we didn’t miss any changes in mapping results just because the samdiff script didn’t work, I ran it manually for each commit since the problem was introduced and can confirm that no other commit caused any changes.

Closes #361

marcelm commented 7 months ago

This is blocking some other PRs and should be uncontroversial, so I’m taking the liberty of merging this without explicit approval.

ksahlin commented 7 months ago

Yes absolutely. Please take the liberty in such occasions in general.

marcelm commented 7 months ago

Thank you! I will do so in the future.