search

ksahlin / strobealign

Aligns short reads using dynamic seed size with strobemers
MIT License
128 stars 16 forks source link

Fix drop in mapping-only accuracy #389

Closed marcelm closed 5 months ago

marcelm commented 5 months ago

Commit 1fe3e34 made a buggy refactoring: I thought that the score attribute of NamPair objects is the same as the sum of the scores of the two constituent NAMs. But that is incorrect: The score is actually the sum of the n_hits.

This PR fixes that and renames NamPair::score to NamPair::n_hits to eliminate this confusion.

ksahlin commented 5 months ago

Nice, approved!