ksahlin / strobealign

Aligns short reads using dynamic seed size with strobemers
MIT License
128 stars 16 forks source link

Set default number of threads to 1 #403

Closed marcelm closed 3 months ago

marcelm commented 3 months ago

Also, adjusted logging output to make it more obvious how many threads are used (and which mode). Example:

...
Total time indexing: 3.79 s
Processing paired-end reads in mapping-only mode using 1 worker thread
 Mapped         1.00 M reads @    11.02 us/read
Done!

Other example messages:

Processing single-end reads in abundance estimation mode using 4 worker threads
...
Processing single-end reads using 4 worker threads

Closes #401

ksahlin commented 3 months ago

Great! About your comment on making it 'easily interpretable' for less experienced users (https://github.com/ksahlin/strobealign/issues/401); what do you think about removing 'worker' in 1 worker thread and just state using 1 thread?

One may think that worker threads are not directly related to number of threads the program is using. For example, in the producer/consumer solution there is one producer and several consumers that sometimes might be confused with 'workers'.

marcelm commented 3 months ago

One may think that worker threads are not directly related to number of threads the program is using.

I somehow misremembered that the main thread does the I/O, so it was actually my intention to convey that there are more than $n$ threads, but checking the code, I see that that isn’t the case: The main thread only prints the progress indicator, so it shouldn’t be counted. I have changed the text as you suggested.

ksahlin commented 3 months ago

Great, approved!