search

ksahlin / strobealign

Aligns short reads using dynamic seed size with strobemers
MIT License
128 stars 16 forks source link

Better fix for #409 #411

Closed drtconway closed 3 months ago

drtconway commented 3 months ago

I've reworked the change I proposed earlier to use std::regex which makes it neater.

It now splits on whitespace, then checks that the name is SAM-compatible.

marcelm commented 3 months ago

Nice, thanks! This looks fine now.

Just a note: It is more customary to modify an existing PR until it is satisfactory because otherwise the previous discussion (as in #410) is lost. But no worries, this is not a problem here.

marcelm commented 3 months ago

I added a couple of tests in 444c94858c2f7de74a1468adb1992e2f7f865385 and a changelog entry in c3ea0d250d4c528e30c9205a9546375e33400bf6.