search

ksallberg / iexcloud

BSD 3-Clause "New" or "Revised" License
6 stars 2 forks source link

getTS from/to time params #3

Open madjestic opened 4 years ago

madjestic commented 4 years ago

Hey guys,

getTS :: AuthAndSymbol -> IO (Maybe [IEXTimeSeries.TimeSeries]) - it looks like the function interface is not supporting arguments, such as from/to time bounds, mentioned as Query String Parameters in the API?

Take, for example, this call: https://sandbox.iexapis.com/stable/time-series/REPORTED_FINANCIALS/AAPL/10-Q?from=2018-01-01&to=2019-06-01&token=Tsk_ suggests that you can provide time-range from/to arguments, but I don't see how it fits into the getTS :: AuthAndSymbol ... interface? Or is that part of auth argument?
Should it not be more like: getTS :: AuthAndSymbol -> QSParms -> IO (Maybe [IEXTimeSeries.TimeSeries]), where QSParms stands for Query String Parameters ?

Cheers, Vlad

ksallberg commented 4 years ago

I don't have time to look at this right now, but I think that no-one ever used this function yet. I invited you as a collaborator to this project so that you can push code and play around if you wish