search

ksassnowski / venture

Venture allows you to create and manage complex, async workflows in your Laravel apps.
https://laravel-venture.com
MIT License
804 stars 32 forks source link

Add test for handling jobs with protected and private properties #49

Closed stevebauman closed 2 years ago

stevebauman commented 2 years ago

Closes #42

This PR adds a test for ensuring a job with protected and private properties can be properly serialized and unserialized from the jobs database table.

ksassnowski commented 2 years ago

Hm, I feel like this is just a test for PHP’s serialize function, no? It's not really related to anything the package does in particular.

stevebauman commented 2 years ago

This test is mainly for closing out #42 so we can ensure jobs that are added to the workflow on a database connection are properly dispatched and stored in the DB, along with their properties being restorable from unserialize.

Though if you think it's unnecessary then no worries! 👍

ksassnowski commented 2 years ago

Closing this for now as it seems unrelated to what's actually going in #42. The problem seems to stem from using a TEXT field to store the serialized job instead of a BLOB (still unconfirmed, however). What we should do instead, is postgres to our Github Actions as well and see if the test suite passes, which I assume right now it wouldn't.

stevebauman commented 2 years ago

Ok sounds good! 👍