search

ksassnowski / venture

Venture allows you to create and manage complex, async workflows in your Laravel apps.
https://laravel-venture.com
MIT License
804 stars 32 forks source link

Fix | Updated WorkflowEventSubscriber for fix #91

Closed simple-hacker closed 9 months ago

simple-hacker commented 9 months ago

Fixes #90 Using comment by @stevebauman

https://github.com/ksassnowski/venture/issues/90#issuecomment-1958067611

Return early if job does not implement WorkflowableJob interface in WorkflowEventSubscriber.

stevebauman commented 9 months ago

@simple-hacker Thanks for the PR! Tests are failing here for the new changes -- we'll likely have to update them to support retrieving the class names of jobs.

Will wait for Kai's approval on this, as I'm unsure if this is how he'd like to tackle this, and if he has a potentially better solution.

simple-hacker commented 9 months ago

Ah this is my mistake sorry, I didn't mean to do a PR here. I was meant to do a PR in my organisation's forked repo. Just wanted to do a quick check to see if our tests were passing which they were.

I'll close this PR for now and will help investigate the issue properly and submit a better PR with passing tests.

stevebauman commented 9 months ago

Ok sounds good, thanks @simple-hacker! 🙏