tool: adding a about section in the tool - Githubissues

ksauraj / jee_counsellor

"Introducing jee_counsellor - a tool to display colleges based on Jee Mains rank. Get personalized informations based on your rank and make informed decisions.

GNU General Public License v3.0

13 stars 8 forks source link

tool: adding a about section in the tool #14

Closed ksauraj closed 7 months ago

ksauraj commented 7 months ago

In the main menu, we propose adding an 'About' section that will showcase the current version, provide a brief overview of the tool, acknowledge contributors, and include other relevant information. This section aims to offer users a comprehensive understanding of the tool, its evolution, and the people involved in its development.

TheDarkW3b commented 7 months ago

Assign it to me please

ksauraj commented 7 months ago

Assign it to me please

I have already assigned you a issue, after finishing that you can work on this too, But for now I will not be able to assign this to you.

Tholkappiar commented 7 months ago

Can I work on this Issue , if so assign this issue to me ! @ksauraj

ksauraj commented 7 months ago

Can I work on this Issue , if so assign this issue to me ! @ksauraj

Yah sure, I'm assigning it to you.

Tholkappiar commented 7 months ago

Hello @ksauraj , i have added required amount of details , but for the version thing can you give the info about version things ! Added the contributors by the Gitpython library ! Screenshot from 2024-01-16 10-46-32

ksauraj commented 7 months ago

@Tholkappiar I really like your efforts but I want you to implement these changes

Try not adding extra dependencies, like I can understand you need gitpython for checking contribution list in automation but we can add it manually via commit or an action script while release of new version everytime.
Secondly, After checking about section we should have a option to return back to main menu, kinda loop in short.
And at last utilise clear screen function and print ascii art which will match the overall theme of the tool, for reference check this.

Tholkappiar commented 7 months ago

Okay , so for the contributors section , which one ok for you manual adding or you can add the action script and configure it ? I will do the remaining changes as referenced , waiting for you response , thank you !

ksauraj commented 7 months ago

Okay , so for the contributors section , which one ok for you manual adding or you can add the action script and configure it ? I will do the remaining changes as referenced , waiting for you response , thank you !

For now you continue with manual adding, in future we will be adding a script before new release of tool, so for now you can just add my name in "Author" and let the contributor section be empty or just add my name in contributor section too.

Tholkappiar commented 7 months ago

And for version ?

ksauraj commented 7 months ago

And for version ?

Just add version, you can check it here

Also make sure to colorize stuffs 🎨.

Tholkappiar commented 7 months ago

yeah okay , there are n number of versions based on the OS ! which should i choose or display all like key value pairs for the OS with versions ?

ksauraj commented 7 months ago

yeah okay , there are n number of versions based on the OS ! which should i choose or display all like key value pairs for the OS with versions ?

Its v2.0.2 overall in most recent update. -win, -mac, -linux is just tag to differentiate between executable.

Tholkappiar commented 7 months ago

I have made the changes , can i push the changes !

Screencast from 16-01-24 01:19:06 PM IST.webm

ksauraj commented 7 months ago

Seems fine, make a PR.