search

ksauraj / jee_counsellor

"Introducing jee_counsellor - a tool to display colleges based on Jee Mains rank. Get personalized informations based on your rank and make informed decisions.
GNU General Public License v3.0
13 stars 8 forks source link

feat: Added GitHub Workflow For Issues And Pull Requests #29

Closed JiyaGupta-cs closed 6 months ago

JiyaGupta-cs commented 6 months ago

Closes #28

JiyaGupta-cs commented 6 months ago

@ksauraj Please review the PR

ksauraj commented 6 months ago

@ksauraj Please review the PR

Yah I'm reviewing it now.

ksauraj commented 6 months ago

@JiyaGupta-cs do those quick changes, and ig this will be ready to get merged.

JiyaGupta-cs commented 6 months ago

@ksauraj Which changes ?

JiyaGupta-cs commented 6 months ago

@ksauraj Which changes are you referring to? You haven't told me earlier

ksauraj commented 6 months ago

@ksauraj Which changes are you referring to? You haven't told me earlier

image These changes, check those review which i gave.

JiyaGupta-cs commented 6 months ago

@ksauraj Done! Please review

ksauraj commented 6 months ago

Actually I just wanted you to remove

- label: "I have starred the repository"
          required: true

If you can fix this or else I'm ready to merge this too.

JiyaGupta-cs commented 6 months ago

@ksauraj Fixed!!!

ksauraj commented 6 months ago

Great job, @JiyaGupta-cs , and thank you for being patient.

JiyaGupta-cs commented 6 months ago

Great job, @JiyaGupta-cs , and thank you for being patient.

Could you please change the label to hard ? If you like it

ksauraj commented 6 months ago

Could you please change the label to hard ? If you like it

I already merged it, won't count now anyway.