search

kscalelabs / onshape

K-Scale's library for programmatically interacting with OnShape
MIT License
15 stars 3 forks source link

Question about mass properties #41

Closed emrecemal closed 1 week ago

emrecemal commented 3 weeks ago

Hello,

Thank you for the nice repository! I have a question about the generated MJCF file. When I check the generated file, I don't see any definition related to mass properties like inertia. Do I need to add them separately?

budzianowski commented 3 weeks ago

Hi @emrecemal - thanks for raising this! I have created explicit flag for urdf and mjcf creation: https://github.com/kscalelabs/onshape/pull/42

emrecemal commented 3 weeks ago

Thank you for the improvement. However, I couldn't get the update on my local even if I tried to reinstall directly from Github using this code: pip install 'kscale-onshape-library @ git+https://github.com/kscalelabs/onshape.git@master'

budzianowski commented 3 weeks ago

What do you mean by 'get the update'?

emrecemal commented 1 week ago

I get this error:

usage: kol [-h] [-o OUTPUT_DIR] [--debug] document_url
kol: error: unrecognized arguments: --remove_inertia
emrecemal commented 1 week ago

I think the problem was related to the Python version. I was using Python 3.12 while it should have been Python 3.11. Downgrading the version fixed the problem!