kscalelabs / store

K-Scale Labs store
https://robolist.xyz
MIT License
6 stars 4 forks source link

Feature/search-feature #154

Closed EtcetFelix closed 2 weeks ago

EtcetFelix commented 2 weeks ago

What does this PR do?

Adds the search feature for the Robots page and the Parts page, including necessary frontend and backend changes.

What issues does this PR fix or reference?

Search Feature

chennisden commented 2 weeks ago

This is awesome! One thing: could you make it so that the search feature is case insensitive (i.e. 'Robot' matches with 'robot', 'ROBOT', 'rObot', etc)?

EtcetFelix commented 2 weeks ago

Unfortunately, there's 2 problems with this current implementation:

Therefore, I propose merging this PR for now, and opening 2 tasks for the following: Task 1: Fix db writes to add a new field for searching with case-insensitive queries, and change the dynamo db searches to search on that field Task 2: Replace all table.scan operations with either a DynamoDB query method with pagination, or query with boto3 (since the AWS boto sdk provides low level pagination abstraction: https://docs.aws.amazon.com/code-library/latest/ug/python_3_dynamodb_code_examples.html#scenarios)

chennisden commented 2 weeks ago

Bah, unfortunate. I'll open the two issues you have just mentioned and merge the request.

Thanks!

Resolves #154