kscalelabs / store

K-Scale Labs store
https://kscale.store
MIT License
25 stars 24 forks source link

Add .env and env.sh to .gitignore, Create env.sh.example Template #205

Closed omesh-omg closed 1 month ago

omesh-omg commented 1 month ago

These changes enhance security and provide a setup guide for new developers.

chennisden commented 1 month ago

I'm not sure why we're using both .env and env.sh separately? If both react and fastapi pick up on .env that'd be great, but I doubt they do that, which is why I personally used env.sh

But unless I'm missing something, I think the best approach would just be to drop .env entirely.

omesh-omg commented 1 month ago

@chennisden I agree with you but, I wasn't sure it might be required for some command which takes variables from .env but I think env.sh will work everywhere I am removing .env completely.