search

kschiess / parslet

A small PEG based parser library. See the Hacking page in the Wiki as well.
kschiess.github.com/parslet
MIT License
809 stars 95 forks source link

Blankslate removed #131

Closed rubydesign closed 9 years ago

rubydesign commented 9 years ago

Hi, i am fiddling with opal, which doesn't even do the require blankslate. So i took the bull by the horns and surprisingly managed :-) https://github.com/salama/parslet/commit/81220d74fa77a4ede5267d4d6fa6ded922b0c548

There were a couple of methods i had to add back into the context, but nothing too big. I have tested the commit with ruby 1.9.3, 2.0 and 2.1.5, all green. So the commit even removed the dependency from the gemspec and everywhere else off course.

I can off course send a pull request but thought you might want to discuss first.

rubydesign commented 9 years ago

btw. i found a bug in opal that trips over <<self

if we could squeeze a space in there at the same time that would be great. So << "space" self I know it is legal syntax, just opal stumbles. Noticed that after, could you do that? There are two occurrences, in context and in parser. That would be nice. T.

rubydesign commented 9 years ago

any comment ?

kschiess commented 9 years ago

Can you create a PR for both? I will be happy to look at those changes.

kschiess commented 9 years ago

See PR #132 and PR #133.

kschiess commented 9 years ago

See #134

kschiess commented 9 years ago

We were unable to find an implementation that keeps present functionality intact.