search

kschiess / parslet

A small PEG based parser library. See the Hacking page in the Wiki as well.
kschiess.github.com/parslet
MIT License
805 stars 95 forks source link

remove blankslate in favor of BasicObject #132

Closed rubydesign closed 9 years ago

rubydesign commented 9 years ago

I'm sorry my editor messed the whitespace automatically. Should create a problem though. Basically i just removed the blankslate and added equivalent code back in until tests passed

kschiess commented 9 years ago

I know this is probably bothersome; but could I ask you to reformulate a clean PR, with changes only in lines that need to be changed?

Thanks for all the work!

rubydesign commented 9 years ago

i know! i was quite struck when i first started using atom what it does to my whitespace. Now off course i quite like it:-)

Sure, if it bothers you, i can remove the whitespace noise and trim it to essential. I'll do a new pr so you can close #131

rubydesign commented 9 years ago

replaced by #134