search

kschiess / parslet

A small PEG based parser library. See the Hacking page in the Wiki as well.
kschiess.github.com/parslet
MIT License
809 stars 95 forks source link

Include parslet.gemspec and spec directory #136

Closed hggh closed 9 years ago

hggh commented 9 years ago

if you include parslet.gemspec and spec directory it is better for Debian. If this the gemspec and the sepc directory is included into the gem we (at debian) could run the unit tests after build time.

@kschiess atfer merging this PR, could you please release and upload a new version to rubygems?

Thanks!

kschiess commented 9 years ago

This generates cruft for everyone else. Can we agree on just the spec directory, excluding the gemspec?

hggh commented 9 years ago

most gems are shipping the gemspec file within the gem. Our gem2deb inside debian needs the gemspec file for installation. But yeah if you don't wish so, please include the spec files, so we can run tests at build time.

kschiess commented 9 years ago

Nah - if there is really a good reason for this, I'll just do what you propose ;)

Thank you!

hggh commented 9 years ago

Thanks!