search

kschiess / parslet

A small PEG based parser library. See the Hacking page in the Wiki as well.
kschiess.github.com/parslet
MIT License
805 stars 95 forks source link

fix #151 - Rspec has issues with 'cause' on 'Parslet::ParseFailed'. … #160

Closed johnnaegle closed 7 years ago

johnnaegle commented 8 years ago

Rename cause to parse_failure_cause

kschiess commented 8 years ago

I'll merge your PR if you remove all whitespace cleanup from it...

johnnaegle commented 8 years ago

How about I run a code cleaner and remove trailing whitespace on the whole project?

kschiess commented 8 years ago

I don't think that's a good idea. Here's what I would like from you: Make the smallest possible changeset that implements the goal of this PR - then I'll happily merge your contribution.

If you want to clean whitespace, do it where changes are needed anyway.

kschiess commented 7 years ago

I've just merged a PR that fixes this bug.