search

kschiess / parslet

A small PEG based parser library. See the Hacking page in the Wiki as well.
kschiess.github.com/parslet
MIT License
805 stars 95 forks source link

`abort` call in infix.rb #186

Closed olbrich closed 6 years ago

olbrich commented 6 years ago

https://github.com/kschiess/parslet/blob/7ac42d9bbd92345e3decf891256097debe51720b/lib/parslet/atoms/infix.rb#L59

This seems like a bad idea. Hitting this line of code will abruptly terminate your process. Maybe this was supposed to be a raise?

kschiess commented 6 years ago

... you might be right. We obviously don't have a test for this path. Would you be able to provide such a test?

(I'd rather not change this line and still not have a test for it...)