search

kschiess / parslet

A small PEG based parser library. See the Hacking page in the Wiki as well.
kschiess.github.com/parslet
MIT License
805 stars 95 forks source link

is the 'blankslate' dependency strictly necessary anymore? #96

Closed ghost closed 10 years ago

ghost commented 10 years ago

is the 'blankslate' object strictly necessary anymore? I ask because I understood it as being necessary on 1.8 but with 1.9+ we have BasicObject. I depend on parslet indirectly via toml, in a library I maintain called binding.repl. I would love to drop the third dependency(blankslate) and depend on just toml, and then through that, parslet. is this possible, or is BasicObject insufficient in one way or another?

kschiess commented 10 years ago

BlankSlate and BasicObject are essentially not the same thing. BasicObject is much less...

kschiess commented 10 years ago

So, the short answer is: yes.

ghost commented 10 years ago

@kschiess thanks, I'll go ahead and close it. is there anything in particular? it looks like this has few methods, but perhaps one or two more than blankslate: http://www.ruby-doc.org/core-2.1.0/BasicObject.html

kschiess commented 10 years ago

BasicObject has strictly nothing useful in it. It is very hard to work with and violates expectations all over the board. Try replacing BlankSlate with it and fixing the specs ;) This is best seen in practice...

ghost commented 10 years ago

sure, I did fork with that intention, but I was wondering did I miss something, so opened an issue.

ghost commented 10 years ago

thanks! :)