search

kschlichter / Home-Assistant-Inovelli-Effects-and-Colors

Scripts for setting LED indicators and effects on Inovelli products.
36 stars 6 forks source link

Request to change filename #2

Closed coolacid closed 3 years ago

coolacid commented 3 years ago

I'm requesting that https://github.com/kschlichter/Home-Assistant-Inovelli-Red-Dimmer-Switch/blob/master/inovelli_red_dimmer_switch be changed to inovelli_led.yaml so it can be directly used as a git clone/pull without having to rename the file every time.

kschlichter commented 3 years ago

Yes, thanks for pointing that out!

coolacid commented 3 years ago

I recommended inovelli_led.yaml so that when using !include_dir_named scripts in the configuration.yaml file, the script call becomes script.inoveli_led which (to me) is a better description, and shorter then the full filename.

Thanks for the rename.

kschlichter commented 3 years ago

Yeah, that makes sense. Thanks.