kscout / serverless-registry-api

API which curates serverless applications.
https://api.kscout.io
GNU General Public License v2.0
0 stars 1 forks source link

Internal histogram metrics not being placed in buckets correctly #175

Open Noah-Huppert opened 5 years ago

Noah-Huppert commented 5 years ago

The internal duration metrics are not placing entries into buckets correctly. The le label, which is used to specify the bucket, has been set to infinity: le="+Inf".

This isn't very useful b/c most requests are getting put in the infinity bucket.

My initial guess is that using milliseconds is too small of a time unit. Maybe using seconds would work best. The histogram can record float64 values so partial seconds could be published. My initial guess was wrong. The time.Duration type is actually an int64 representing the duration in nanoseconds. In the code we then divide this by the Millisecond unit. I believe you are supposed to multiply.

Action items:

Acceptance criteria: