search

ksedgwic / Wallet32

20 stars 11 forks source link

Starting with 2 accounts is not BIP-0044 compatible. #17

Open prusnak opened 10 years ago

prusnak commented 10 years ago

I noticed that when I start an app it show two accounts by default. This behavior is not compatible with BIP-0044 because specifications says to stop account discovery on first account with no transaction history.

This can lead to unpleasant situation where user uses second account without touching the first one and importing the seed to a different BIP-0044 compatible wallet will results in just first empty account.

Suggestion: show just one account by default and don't allow adding new account if the previously last one is with no transaction history.

dabura667 commented 10 years ago

I would suggest that BIP-0044 be changed to check the first 2 accounts before stopping discovery. I think that most HD wallets will want to show the user that they have the ability to create separate "accounts" or "pockets" or whatever you call them, by making the default have 2 of them.

Stopping default generating at one account will most likely end up with users not knowing the functionality exists.

prusnak commented 10 years ago

I am quite hesitant to make the spec more complex and put more burden on ALL implementers just so some wallets can show off this feature.

If one wants to show off I think that making "Add Account" button more prominent is way better than starting with 2 accounts by default.