kserve / community

KServe community docs for contributions and process
Apache License 2.0
7 stars 3 forks source link

Proposal to add new ModelMesh committers #6

Closed ckadner closed 9 months ago

ckadner commented 9 months ago

We recently codified the process of how outstanding KServe contributors can be promoted to become committers.

This issue starts the process of a first selection of candidates. The output of the list-contributors.py script is used as a reference point to help with selecting candidates.

  1. Top PR authors
  2. Top PR reviewers
  3. Top contributors (PRs authored and/or reviewed)

The contribution activity spans the previous 6 months. Current committers and bot accounts are excluded.

Actual candidates to be promoted will be nominated by current committers and (in this first round of promotions) can be voted on by all contributors.

1. Top PR authors:

$ ./scripts/python/list-contributors.py --repo kserve/modelmesh-serving -n 3 -r author

Contributors to 'kserve/modelmesh-serving' (PR authors) by number of PRs (>3) since 2023-03-22:

 17  rafvasq            [422, 421, 417, 416, 413, 412, 406, 405, 403, 391, 390, 379, ... ]
  7  ckadner            [429, 415, 414, 404, 371, 368, 354]

2. Top PR reviewers:

$ ./scripts/python/list-contributors.py --repo kserve/modelmesh-serving  -n 3 -r reviewer commenter

Contributors to 'kserve/modelmesh-serving' (PR commenters, reviewers) by number of PRs (>3) since 2023-03-22:

 25  ckadner            [428, 425, 422, 421, 417, 416, 413, 412, 406, 405, 403, 400, ... ]
  9  rafvasq            [429, 428, 415, 414, 404, 398, 395, 394, 375]

3. Top contributors (PRs authored and/or reviewed):

$ ./scripts/python/list-contributors.py --repo kserve/modelmesh-serving -n 3

Contributors to 'kserve/modelmesh-serving' (PR authors, commenters, reviewers) by number of PRs (>3) since 2023-03-22:

 32  ckadner            [429, 428, 425, 422, 421, 417, 416, 415, 414, 413, 412, 406, ... ]
 26  rafvasq            [429, 428, 422, 421, 417, 416, 415, 414, 413, 412, 406, 405, ... ]
  3  Jooho              [400, 397, 363]

@njhill

ckadner commented 9 months ago

FYI @rafvasq

ckadner commented 9 months ago

This could look like I am shamelessly self-promoting here, but, Rafael and Jooho are here too. So it's totally legit!

😎

njhill commented 9 months ago

I approve!

ckadner commented 9 months ago

I approve!

Thanks @njhill -- I created 3 PRs to update the OWNERS files in the ModelMesh repos that use it.

chore: Add new approvers to OWNERS file kserve/modelmesh#109 chore: Add new approvers to OWNERS file kserve/modelmesh-runtime-adapter#56 chore: Add new approvers to OWNERS file kserve/modelmesh-serving#437

ckadner commented 9 months ago

Thanks @njhill