kserve / modelmesh-minio-examples

ModelMesh example models packaged into a MinIO container for user exploration and functional verification testing
Apache License 2.0
2 stars 18 forks source link

Update docker base images #8

Open bdattoma opened 7 months ago

bdattoma commented 7 months ago

I've noticed that the base docker image is 2 years old, so I thought it could be worth to update the dockerfile

What do you think?

oss-prow-bot[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bdattoma

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kserve/modelmesh-minio-examples/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
bdattoma commented 7 months ago

sorry this doesn't work well with console UI because it doesn't assign correctly permissions to the right user. I wasn't able to add a new user using the minio base image, so I guess in order to achieve the image update you should update the quay.io/cloudservices/minio image to fetch latest minio. Where can I find the dockerfile for quay.io/cloudservices/minio ?