search

kserve / modelmesh-runtime-adapter

Unified runtime-adapter image of the sidecar containers which run in the modelmesh pods
Apache License 2.0
21 stars 59 forks source link

fix: build all binaries for the target OS/ARCH #49

Closed tjohnson31415 closed 1 year ago

tjohnson31415 commented 1 year ago

Motivation

Fix the multi-arch builds so that all binaries are built for the target OS/ARCH. Currently, only the puller is built for the target.

Modifications

Result

kserve-oss-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhill, tjohnson31415

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kserve/modelmesh-runtime-adapter/blob/main/OWNERS)~~ [njhill,tjohnson31415] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
njhill commented 1 year ago

/lgtm