search

kserve / modelmesh-runtime-adapter

Unified runtime-adapter image of the sidecar containers which run in the modelmesh pods
Apache License 2.0
21 stars 59 forks source link

feat: Make container build engine configurable #87

Closed spolti closed 2 weeks ago

spolti commented 4 months ago

chore: Allow to run make goals provinding the desired Container Enginer builder tool, e.g. ENGINE=podman make build

Motivation

Modifications

Result

oss-prow-bot[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kserve/modelmesh-runtime-adapter/blob/main/OWNERS)~~ [ckadner] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
spolti commented 3 months ago

@ckadner do you think it can be merged?

spolti commented 2 weeks ago

Hi @ckadner, do you think we can merge it?

cc @rafvasq

spolti commented 2 weeks ago

Thanks.