kserve / modelmesh-serving

Controller for ModelMesh
Apache License 2.0
202 stars 114 forks source link

Remove residual "Watson" references #292

Open njhill opened 1 year ago

njhill commented 1 year ago

Model-mesh was originally developed as part of IBM Watson. Now that it is part of KServe we should scrub any remaining places that "watson" is used in the codebase, at least starting with those that are straightforward to change.

ScrapCodes commented 1 year ago

Hi Nick @njhill , does this issue include changing package names in proto files from "com.ibm.watson" to may be "io.kserve" ?

njhill commented 1 year ago

@ScrapCodes apologies for missing your message here originally. Yes I think that would be good, though I'm actually not sure whether KServe owns the kserve.io domain. We shouldn't change the proto package itself but the package for generated java stubs should be fine to change.

I would suggest holding off on changing the java package of the rest of the modelmesh code for now, let's just cover other less invasive things first, like directory names within the container, etc. Then we can do the java package renaming in a second pass.

Giles-Billenness commented 1 year ago

This looks like a good first issue to start contributing to this project. I joined the open-source programme @ IBM and have @rafvasq mentoring me for contributions to this project. I am interested in this project as ML workflows are an area of interest, from studying and focusing on it at university.

ScrapCodes commented 1 year ago

@Giles-Billenness You are welcome, to work on it! /assign @Giles-Billenness

AshleyZhao commented 1 year ago

Hello, Is this issue complete? If not I'd also like to take this or another similar issue. @rafvasq @Giles-Billenness @ScrapCodes

rafvasq commented 1 year ago

Hey @AshleyZhao, thanks for the interest! I believe @Giles-Billenness is looking into this but had the obstacle M1 chip support which was only introduced in the past few days or so. Let's see if Giles confirms he still has time to look at this before you take it on.

Giles-Billenness commented 1 year ago

Hey, thanks for the update. I will be taking a look at this again given the hardware support