search

kserve / modelmesh-serving

Controller for ModelMesh
Apache License 2.0
200 stars 113 forks source link

KServe client gets stuck on watching and waiting for ModelMesh inference services #383

Open danilopeixoto opened 1 year ago

danilopeixoto commented 1 year ago

Describe the bug

KServe client gets stuck on watching and waiting for ModelMesh inference services.

Is ModelMesh inference service missing observedGeneration field?

https://github.com/kserve/kserve/blob/c4978eed4f78c1ea210b3c686a16fff8187c42d6/python/kserve/kserve/api/watch.py#L54

To Reproduce

client.create(isvc, watch=True)

Expected behavior

Stop the loop when Kubernetes sets Ready condition to True.

Screenshots

Not applicable.

Environment (please complete the following information):

Additional context

No.

ckadner commented 1 year ago

@njhill - were you aware of these changes in KServe v0.10.0?

https://github.com/kserve/kserve/pull/1925

AFAICR I have not noticed the observedGeneration field on ModelMesh ISVCs