search

kserve / modelmesh-serving

Controller for ModelMesh
Apache License 2.0
199 stars 112 forks source link

The behavior of `certificate` in StorageSpec is different from Kserve #460

Open Jooho opened 9 months ago

Jooho commented 9 months ago

Is your feature request related to a problem? If so, please describe. certificate in KServe can be set by serving.kserve.io/s3-bundle and this field is for the path of ca bundle certificate.

However, in modelmesh, this is ca bundle certificate content

To me, kserve way would be the right approach. KServe provide a way to attach a configmap for cabundle and also can change the cert path globally. Moreover, it also can be set by StorageSpec

Describe your proposed solution Modelmesh need to implement the same reconciler to copy the ca configmap to the user namespace and follow the same behavior of kserve one.

Describe alternatives you have considered

Additional context

Jooho commented 2 months ago

Modelmesh was using another way to support dynamic update of certificate without restarting runtime pod. However, if we use configmap like kserve, I think it does not need to restart runtime. So we can consider to change this.