search

kserve / modelmesh-serving

Controller for ModelMesh
Apache License 2.0
189 stars 106 forks source link

chore: Update to Go 1.20, kserve v0.11.2 #470

Closed ckadner closed 5 months ago

ckadner commented 6 months ago

Motivation

Trying to prepare for the v0.12 release, but stuck sticking with kserve v0.11.2 for the time being since kserve v0.12.0-rc0 requires Go 1.21 which requires much more extensive changes (i.e. no available UBI image for Go 1.21, ...)

Modifications

Updated versions:

Result

TBD

oss-prow-bot[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, rafvasq, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kserve/modelmesh-serving/blob/main/OWNERS)~~ [ckadner,rafvasq] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
oss-prow-bot[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, rafvasq, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kserve/modelmesh-serving/blob/main/OWNERS)~~ [ckadner,rafvasq] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
spolti commented 5 months ago

Thanks Christian, think this is fine even as a step towards 1.21 while we figure out more details about the UBI image for it.

For cases where we don't yet have a UBI image for it, we probably can use the minimal/micro and install go manually.