search

kserve / modelmesh-serving

Controller for ModelMesh
Apache License 2.0
202 stars 114 forks source link

fix: Install fails with int commit hash #473

Closed ckadner closed 8 months ago

ckadner commented 8 months ago

Motivation

See #472

Modifications

Resolves #472

ckadner commented 8 months ago

I reproduced/forced the original error in commit https://github.com/kserve/modelmesh-serving/pull/473/commits/20d00fcaae7fa2653c550e8f4ab13d371571a938

Find the full error log here: https://github.com/kserve/modelmesh-serving/actions/runs/7468073047/job/20322809022?pr=473#step:11:57

oss-prow-bot[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kserve/modelmesh-serving/blob/main/OWNERS)~~ [ckadner,rafvasq] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment