search

kserve / modelmesh-serving

Controller for ModelMesh
Apache License 2.0
205 stars 114 forks source link

Add ginkgo cli to be installed as part of the `fvt` make goal. #491

Open spolti opened 9 months ago

spolti commented 9 months ago

Describe the bug

If you don't have ginkgo installed and try to run the fvt tests it will fail.

make fvt
ginkgo -v -procs=2 --fail-fast fvt/predictor fvt/scaleToZero fvt/storage fvt/hpa --timeout=50m
make: ginkgo: No such file or directory
make: *** [fvt] Error 1

To Reproduce Steps to reproduce the behavior:

  1. Make sure you don't have ginkgo available in the $PATH
  2. run make fvt

Expected behavior

Install ginkgo for the user if it is not available.