docs: Include the required jq dependency

medinad96 commented 7 months ago

Motivation

Followed the quickstart and ran into "jq not found" when running the following command. Quickstart link

./scripts/install.sh --namespace modelmesh-serving --quickstart --enable-self-signed-ca

The following change made jq a necessary dependency:

https://github.com/kserve/modelmesh-serving/blob/91b610bd1bcd8d5264dcd696db4e2b65730f7468/scripts/self-signed-ca.sh#L136-L139

Modifications

Modified the list under the following link to point to where jq can be downloaded or installed https://github.com/kserve/modelmesh-serving/blob/main/docs/quickstart.md#prerequisites

Result

The prerequisites list has the link detailed below.

rafvasq commented 7 months ago

Thanks @medinad96! Can you please follow the instructions here to sign off your commit (DCO)?

oss-prow-bot[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medinad96, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kserve/modelmesh-serving/blob/main/OWNERS)~~ [rafvasq] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment