search

kserve / modelmesh-serving

Controller for ModelMesh
Apache License 2.0
189 stars 106 forks source link

feat: add S390x support in affinity rule #503

Closed modassarrana89 closed 1 month ago

modassarrana89 commented 2 months ago

Added s390x in node affinity rule as already work is going on to support s390x for tensorflow in runtime-adaptor

modassarrana89 commented 2 months ago

@njhill @ckadner @rafvasq Can you guys please review & do the needful

modassarrana89 commented 2 months ago

/assign @njhill

modassarrana89 commented 1 month ago

@rafvasq I have updated the comment & lint the changes on x86. Please review & do the needful

ckadner commented 1 month ago

@modassarrana89 -- I updated your branch and fixed the linting issue

ckadner commented 1 month ago

/lgtm

oss-prow-bot[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, modassarrana89, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kserve/modelmesh-serving/blob/main/OWNERS)~~ [ckadner,rafvasq] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
oss-prow-bot[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, modassarrana89, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kserve/modelmesh-serving/blob/main/OWNERS)~~ [ckadner,rafvasq] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment